RE: More Addict 3 Beta Bugs

["Steve Moss" <address@hidden>]

Hi Michael:

>> Hate to have you do all of my work for me...  :-) <<

You're welcome! ;-) Many components out there are not worth the trouble, but
I have to say Addict very much is.

>> Addict.Configuration.Modified := False;
Addict.Configuration.ReloadConfiguration; <<

Ah, many thanks. Missed the Modified property.


>> OK... I've added nntp://, file://. <<

Just to be picky, you might as well complete the picture, and add https://,
telnet:// and wais://.

>> I've also added:

www.xxx.com

and

www.xxx.com/blah/blah.htm <<

Will these be general enough to handle all other domains, such as .co.uk?
Maybe these should be www.xxx and www.xxx/blah ...?

------------------------------
Regards,
Steve Moss ( mailto:address@hidden <mailto:address@hidden> )
CoCo Systems Ltd., 6 Pine View, Muxton,
Telford, Shropshire TF2 8QX, U.K.

URL: http://www.coco.co.uk <http://www.coco.co.uk/>
Tel: +44 (0)7000-COCOTN (262686)
Fax: +44 (0)7000-COCOFN (262636)

S/MIME and PGP capable.



-----Original Message-----
From: Addictive Software [mailto:address@hidden
Sent: 15 February 2001 09:55
To: address@hidden
Subject: RE: More Addict 3 Beta Bugs


> 1. The TAddictLiveRichEdit component does not allow for rich edit controls
> being freed by an application (say, an MDI app which closes and opens
> document windows frequently). If you close (free) a rich edit control and
> then use the configuration dialog to change a configuration, your app will
> crash.
>
> The cause appears to be that TAddictLiveRichEdit has set the TAddictSpell3
> component's OnAddCustomIgnore, OnConfigChanged and OnParserIgnoreWord
> properties, but fails to clear them in its destructor. The TAddictSpell3
> component will attempt to call on these when you change a
> configuration, but
> of course the target object has already been destroyed...
> ... adding suitable nil assignments in TAddictLiveRichEdit.Destroy will do
> the trick (and it may be you need also to initialise the
> FOldOnAddIgnore and
> FOldOnConfigChanged properties in TAddictLiveRichEdit.Create (but I may be
> overly fussy here)).

Hate to have you do all of my work for me...  :-)
Yes, first, all of the events should have been init'd to nil.
Second, when assigning the events back to AddictSpell, they should have been
nil'd out.
Third, when destroying the LiveRichEdit, AddictSpell needed set to nil
(which would automatically unhook all of the events).


> 2. Is there a way to discard configuration changes which have not been
> changed? I would like to do this if the user cancels a
> configuration dialog
> and , say, has changed active dictionaries. The
> TAddictConfig.ReloadConfiguration method actually saves the configuration
> before re-loading it.

Addict.Configuration.Modified := False;
Addict.Configuration.ReloadConfiguration;

The above code should do it for you (I believe)... let me know if it
doesn't...  Reload does intentionally save the configuration first...  its
primarily a tool for Addict to cause a save and reload when something major
about the configuration changes (such as the configuration key or the
storage location).


> 3. The soInternet options does not cause Addict to ignore many URL forms.
It
> catches those prefixed with http:// or ftp://, but misses other protocol
> prefixes such as nntp:// or file://, and also does not catch web URLs
> without the http prefix, such as www.xxx.com. Can this feature be enhanced
> before release?

Ummm... yes ?  :-)

OK... I've added nntp://, file://.
I've also added:

www.xxx.com

and

www.xxx.com/blah/blah.htm



Best Wishes,

Michael Novak
Addictive Software
address@hidden
http://www.addictive.net